Fix LegacyKeyValueFormat report from docker build: disabled#153224
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 4, 2026
Merged
Conversation
rustbot
added
A-CI
homersimpsons
commented
Feb 28, 2026
marcoieni
reviewed
Mar 3, 2026
| ENV RUST_CONFIGURE_ARGS --enable-extended | ||
| ENV SCRIPT python3 ../x.py dist --host='' --target x86_64-unknown-redox | ||
| ENV RUST_CONFIGURE_ARGS="--enable-extended" | ||
| ENV SCRIPT="python3 ../x.py dist --host= --target x86_64-unknown-redox" |
Member
There was a problem hiding this comment.
why you edited --host='' to --host=?
same in riscv.
Contributor
Author
There was a problem hiding this comment.
I explained it in #153224 (comment)
Note that if I preserve the '' I have a different output:
SCRIPT_SOURCE=python3 ../x.py --stage 2 test --host= --target riscv64gc-unknown-linux-gnu
SCRIPT_TARGET=python3 ../x.py --stage 2 test --host='' --target riscv64gc-unknown-linux-gnu
From my understanding docker is parsing the quotes with the previous syntax while it does not touch them with the new one.
Member
|
The disabled jobs can't run in CI. So I will just approve this without running |
Member
|
@bors r+ rollup=always |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
Rollup of 5 pull requests Successful merges: - #153341 (std: refactor Xous startup code) - #152816 (Check for region dependent goals on type_op itself as well) - #153224 (Fix LegacyKeyValueFormat report from docker build: disabled) - #153274 (Fix async drop multi crate crash) - #153324 (fix autodiff parsing for non-trait impl)
rust-timer
added a commit
that referenced
this pull request
Mar 4, 2026
Rollup merge of #153224 - homersimpsons:chore/fix-LegacyKeyValueFormat-disabled, r=marcoieni Fix LegacyKeyValueFormat report from docker build: disabled Part of #152305 Following #153109 r? @marcoieni
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #152305
Following #153109
r? @marcoieni